Fix update_model function#13
Merged
Merged
Conversation
Contributor
saipavan10-git
left a comment
There was a problem hiding this comment.
Reviewed the changes and ran the test debugger on test_orm.py. The code works as expected.
saipavan10-git
approved these changes
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Fixes the
update_modelfunction.Why was this change made?
Passing kwargs as the last parameter was causing
update_modelto not behave as expected when not explicitly setting pk_field.Verification
test_ormto make sure the logic is soundAffirmations
All of these should have a check by them. Any exception requires an explanation.
README,CHANGELOG, and such).